HGI-6804: add target_state #7
Conversation
ghost
requested review from
ghost
self-assigned this
| @@ -1,41 +1,46 @@ | |||
| #!/usr/bin/env python | |||
|
|
|||
| from setuptools import setup | |||
There was a problem hiding this comment.
Why do we have changes in this file?
|
|
||
| try: | ||
| import tests.utils as test_utils | ||
| import tests.utils as test_utils # type: ignore |
There was a problem hiding this comment.
Why do we have changes in the tests folder?
target_postgres/__init__.py
Outdated
| batch_summary["updated"] += updated_lines | ||
| except Exception as e: | ||
| for batch_bookmark in batch_bookmarks: | ||
| batch_bookmark["reason"] = str(e) |
There was a problem hiding this comment.
I think this should actually be "error" – I didn't give you a good example for that, sorry
target_postgres/__init__.py
Outdated
| "hash": build_record_hash(record), | ||
| "success": True, | ||
| "external_id": record.get('cid',""), | ||
| "reason": "" |
target_postgres/__init__.py
Outdated
| "hash": build_record_hash(record), | ||
| "success": False, | ||
| "external_id": record.get('cid',""), | ||
| "reason": str(e) |
There was a problem hiding this comment.
Same feedback as below, this should be "error"
target_postgres/__init__.py
Outdated
| batch_state["bookmarks"][stream].append({ | ||
| "hash": build_record_hash(record), | ||
| "success": False, | ||
| "external_id": record.get('cid',""), |
There was a problem hiding this comment.
What is cid in this context? Is it guaranteed to always exist or was it just an example from your data.singer? In other targets we check if the user has supplied externalId and if not we don't include this external_id in the bookmark for this record
There was a problem hiding this comment.
It was particular to the data.singer. Fixed to check if externalId was supplied.
2 participants
No description provided.