Don't continue uploading when server is down#66
Open
martijnhoekstra wants to merge 2 commits intohotsapi:masterfrom
Open
Don't continue uploading when server is down#66martijnhoekstra wants to merge 2 commits intohotsapi:masterfrom
martijnhoekstra wants to merge 2 commits intohotsapi:masterfrom
Conversation
added 2 commits
January 28, 2020 11:42
set all line endings to lf include .editorconfig to enforce lf endings .editorconfig also set to OTBS, but files not (yet) updated as the diff for a cosmetic change would be significant
Collaborator
Author
|
Conflicts and should wait for #56 |
martijnhoekstra
changed the title
Collaborator
Author
|
Fixes #8 |
martijnhoekstra
commented
Jan 28, 2020
|
|
||
| private Func<ReplayFile, Task> UploadCallback = _ => Task.CompletedTask; | ||
|
|
||
| public event Action<DateTime> NotifyServerDownUntil; |
Collaborator
Author
There was a problem hiding this comment.
Not tested yet in unit tests, as conflicts with #56 in test setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change on top of #65 as to split the functional and the formatting diff.