Try catch in initializing Uniswap contracts so it doesn't fail when Uniswap hasn't initialized a V2 instance #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…niswap hasn't deployed a V2 instance
fengtality
approved these changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
LGTM
@rapcmia I tested this PR to verify that it fixed the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Try catch in Uniswap initializer. Simpler solution to #548 replaces #551
Tests performed by the developer:
Trade on Celo Uniswap with and without this addition.
Tips for QA testing:
Trade on Celo Uniswap with and without this addition.