Add header casing public API #3971
Conversation
src/ext/mod.rs
Outdated
| /// Inserts a header spelling, replacing any existing ones associated with that header name. | ||
| #[cfg(all(any(feature = "client", feature = "server"), feature = "http1"))] | ||
| pub fn insert(&mut self, name: HeaderName, orig: Bytes) -> Result<(), InvalidHeaderName> { | ||
| HeaderName::from_bytes(&orig)?; |
There was a problem hiding this comment.
Clever! Hm, at the same time, it worries me a little to be validating, not parsing. It does mean a user can't round trip from get_all to insert without having to validate again.
At the same time, is it really worth having a separate CasedHeaderName type? Maybe it is... This is probably the hardest question with making this public.
Also, I think HeaderName::from_bytes() will allocate a new copy... That could probably be handled with from_maybe_shared, but just wanted to note for myself at least.
There was a problem hiding this comment.
HeaderName doesn't seem to have from_maybe_shared, that seems to be exclusive to HeaderValue?
Anyway, I added a CasedHeaderName type. Usage is a bit clunky since its used like .insert(CasedHeaderName::new(name, orig).unwrap()).
There's also a From<Bytes> implementation that infers the header name by parsing it.
The ::new(HeaderName, Bytes) constructor checks that the provided Bytes matches the supplied HeaderName.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
2 participants
Addresses #2695 by exposing a public API for HeaderCaseMap
Basically we validate the original spelling bytes by just parsing it as a HeaderName.
Maybe we need to further validate by comparing equivalence? But I'm not sure.
First time contributing to Hyper, let me know if there are issues!