Add Support for JSON Schema Draft-04 Keywords #130

srivastava-diya · 2026-01-16T09:40:07Z

Added Support for JSON Schema Draft-04 Keywords

I have implemented full support for the requested Draft-04 keywords in @hyperjump/json-schema-errors.
Issue : #119

Changes made

`items` and `additionalItems`

Draft-04 treats items and additionalItems as siblings where additionalItems validation depends on items (if items is an array).

Implementation: Implemented a items normalization handler in items.js.
The items handler infers the URI of the sibling additionalItems keyword (by string manipulation of the items URI) and retrieves the schema from the AST. It then acts as the validator for the "tail" items that fall under additionalItems criteria.

`dependencies`

Implemented dependencies.js to handle both:

Schema Dependencies: Delegating validation to the dependent schema.
Property Dependencies: Checking for missing required properties (handled in error handler).

Numeric Keywords (`maximum`, `minimum`)

Implemented handlers maximum.js, minimum.js.

These keywords depend on keywords like exclusiveMaximum (boolean).
The error handlers navigate up the schema URI hierarchy to retrieve the parent schema and check the sibling values (e.g. exclusiveMaximum) to construct the correct error message ("less than" vs "less than or equal to").

Also Added test cases

srivastava-diya · 2026-01-16T10:18:39Z

@jdesrosiers please have a look whenever you're free,because i feel a lot of it needs to be re iterated over

jdesrosiers

This is a quick review. I didn't have enough time to look over everything in much detail.

Make sure you're working with @Adityakumar37 on the items/additionalItems keywords. I'm hoping to merge that PR first, then you can rebase and add the rest of the draft-04 implementation on top of that.

Anyway, your approach for those keywords isn't right. Those are simple applicators. Simple applicators don't need error handlers. Your normalization handlers should look a lot like the keywords from draft-2020-12 that serve the same purpose.

dependencies is a weird one because it's a simple applicator in some cases (schemas) and a validation keyword in other cases (string array). It can even do both at the same time. I need to go through that handler closer later, but it seems like it should be a problem.

src/error-handlers/draft-04/maximum.js

src/error-handlers/draft-04/dependencies.js

src/normalization-handlers/draft-04/additionalItems.js

src/error-handlers/draft-04/dependencies.js

srivastava-diya · 2026-01-19T04:45:22Z

hey @jdesrosiers ,
i have re-written a few normalization handlers in order to closely resemble some draft-2020-12 handlers. and foe the error handlers i think we only need it for dependencies , maximum, and minimum i have also changed them a bit and at the same time i am waiting for aditya's PR in order to rebase and work on top of those changes.

jdesrosiers

Looks pretty close now. The only thing I haven't looked at yet is the tests.

src/error-handlers/draft-04/dependencies.js

jdesrosiers · 2026-01-19T18:00:20Z

src/error-handlers/draft-04/maximum.js

+    const parentLocation = schemaLocation.replace(/\/maximum$/, "");
+    const parent = await getSchema(parentLocation);
+    const exclusiveNode = await Schema.step("exclusiveMaximum", parent);
+    const exclusive = /** @type boolean */ (Schema.value(exclusiveNode) ?? false);


This won't always work. You have to find the value using the keyword URI, not the keyword name. See the contains error handler for an example.

Actually, contains isn't quite right either because it considers values from other schemas applied to the same location. You're going to have find a solution that doesn't hardcode the keyword name, but only considers keywords in the same subschema.

should i use the Regex approach?

Definitely not. You can't depend on the keyword names being consistent. You can only depend on keyword URIs. JSON Schema vocabularies allow for a lot of a lot of things including changing the names of keywords. For example, someone might create a vocabulary that includes all the standard keyword, but translated to another language. So, the actual keyword name might be máximo (spanish) instead of maximum, but it would still have the same keyword URI and be able to be handled by this handler.

So, you need to find a solution that's based on the keyword URI. That's mostly not a problem because the normalized output will include the keyword based on its URI (see the contains handler), but you'll need to add something to make sure you're only considering keywords in the same schema. You should be able to do that with some pointer manipulation in this case, but it won't work for contains when we get the draft-06 support because of references. But, don't worry about that for now.

src/error-handlers/draft-04/maximum.js

src/normalization-handlers/draft-04/dependencies.js

- Add normalization handlers - Add error handlers - Fix type handling and numeric count/matchCount constraints - Update draft-04 test suite

feat(draft-04): add support for JSON Schema Draft-04 keywords - Add normalization handlers - Add error handlers - Fix type handling and numeric count/matchCount constraints - Update draft-04 test suite A fix normalization and error handlers Signed-off-by: Diya <[email protected]> fix: normalization and error handlers for draft-04 fix type checks revert minimum and maximum error handler

srivastava-diya · 2026-01-21T05:09:02Z

hey @jdesrosiers
I’m still thinking through about a proper workaround for the draft-04 maximum and minimum error handlers.
Just wanted to confirm once I find a satisfactory fix for that, would it be okay to take this PR out of draft mode?

jdesrosiers · 2026-01-21T18:22:24Z

Just wanted to confirm once I find a satisfactory fix for that, would it be okay to take this PR out of draft mode?

We want to merge #131 first, so let's keep this in draft until that's merged. Other than that, yes. I'll review now, but I think it's mostly ready with exception of that one part.

jdesrosiers

I added a couple more comments in the dependencies error handler. I also took a look at the tests this time. I skipped the items/additionalItems tests because I expect those to come from the other PR, but the rest of the tests look good enough.

jdesrosiers · 2026-01-21T18:27:56Z

src/error-handlers/draft-04/dependencies.js

+      continue;
+    }
+
+    if (normalizedErrors["https://json-schema.org/keyword/draft-04/dependencies"][schemaLocation]) {


This if isn't necessary. In this case, the value could be true or NormalizedOutput[]. We already checked if it's true, so the only thing left that it could be is NormalizedOutput[].

You could change the ... === true check above to typeof ... === "boolean". That would accomplish the same thing and you wouldn't have cast on the next line here.

jdesrosiers · 2026-01-21T18:34:09Z

src/error-handlers/draft-04/dependencies.js

+    const compiled = await getSchema(schemaLocation);
+    const dependencies = /** @type {Record<string, string | string[]>} */ (Schema.value(compiled));
+
+    for (const property in dependencies) {


It's better to use the AST functions here especially because there could be schemas with references in this value.

Suggested change

const compiled = await getSchema(schemaLocation);

const dependencies = /** @type {Record<string, string | string[]>} */ (Schema.value(compiled));

for (const property in dependencies) {

const dependencies = await getSchema(schemaLocation);

for await (const [property, dependency] of Schema.entries(dependencies)) {

jdesrosiers · 2026-01-21T19:11:34Z

src/error-handlers/draft-04/dependencies.js

+      if (Array.isArray(dependencies[property])) {
+        const missing = dependencies[property].filter((required) => !Instance.has(required, instance));


Once we know it's an array, it's reasonable to convert it to a value.

Suggested change

if (Array.isArray(dependencies[property])) {

const missing = dependencies[property].filter((required) => !Instance.has(required, instance));

if (Schema.typeOf(dependency) === "array") {

const dependentRequired = /** @type string[] */ (Schema.value(dependency));

const missing = dependentRequired.filter((required) => !Instance.has(required, instance));

jdesrosiers · 2026-01-21T19:14:32Z

src/test-suite/tests/dependencies.json

+  "tests": [
+    {
+      "description": "dependencies with schema",
+      "compatibility": "=4",


This version of dependencies is used through draft-07.

Suggested change

"compatibility": "=4",

"compatibility": "<=7",

jdesrosiers · 2026-01-21T19:24:41Z

src/test-suite/tests/maximum.json

+      "errors": [
+        {
+          "messageId": "maximum-message",
+          "messageParams": {"maximum": "3" },


Formatting

Suggested change

"messageParams": {"maximum": "3" },

"messageParams": { "maximum": "3" },

jdesrosiers · 2026-01-21T19:25:05Z

src/test-suite/tests/maximum.json

+      "errors": [
+        {
+          "messageId": "exclusiveMaximum-message",
+          "messageParams": {"exclusiveMaximum": "3" },


Formatting.

Suggested change

"messageParams": {"exclusiveMaximum": "3" },

"messageParams": { "exclusiveMaximum": "3" },

jdesrosiers · 2026-01-21T19:27:31Z

src/test-suite/tests/maximum.json

    }
  ]
-}
+}


All files should end with a newline. I suggest changing your editor settings to add these automatically.

jdesrosiers reviewed Jan 18, 2026

View reviewed changes

src/error-handlers/draft-04/maximum.js Outdated Show resolved Hide resolved

src/error-handlers/draft-04/dependencies.js Outdated Show resolved Hide resolved

src/normalization-handlers/draft-04/additionalItems.js Outdated Show resolved Hide resolved

jdesrosiers reviewed Jan 19, 2026

View reviewed changes

src/error-handlers/draft-04/dependencies.js Outdated Show resolved Hide resolved

srivastava-diya changed the title ~~Added Support for JSON Schema Draft-04 Keywords~~ Add Support for JSON Schema Draft-04 Keywords Jan 19, 2026

jdesrosiers reviewed Jan 19, 2026

View reviewed changes

srivastava-diya force-pushed the main branch from f7169c9 to 5e9987f Compare January 21, 2026 02:29

srivastava-diya added 2 commits January 21, 2026 09:11

feat(draft-04): add support for JSON Schema Draft-04 keywords

8df7abf

- Add normalization handlers - Add error handlers - Fix type handling and numeric count/matchCount constraints - Update draft-04 test suite

srivastava-diya force-pushed the main branch from 80282d2 to c0a8983 Compare January 21, 2026 03:45

jdesrosiers reviewed Jan 21, 2026

View reviewed changes

jdesrosiers mentioned this pull request Jan 21, 2026

Add support for draft-2019-09 #131

Open

		if (Array.isArray(dependencies[property])) {
		const missing = dependencies[property].filter((required) => !Instance.has(required, instance));

-      if (Array.isArray(dependencies[property])) {
-        const missing = dependencies[property].filter((required) => !Instance.has(required, instance));
+      if (Schema.typeOf(dependency) === "array") {
+        const dependentRequired = /** @type string[] */ (Schema.value(dependency));
+        const missing = dependentRequired.filter((required) => !Instance.has(required, instance));

	"messageParams": {"maximum": "3" },
	"messageParams": { "maximum": "3" },

	"messageParams": {"exclusiveMaximum": "3" },
	"messageParams": { "exclusiveMaximum": "3" },

Uh oh!

Add Support for JSON Schema Draft-04 Keywords #130

Are you sure you want to change the base?

Add Support for JSON Schema Draft-04 Keywords #130

Uh oh!

Conversation

srivastava-diya commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Added Support for JSON Schema Draft-04 Keywords

Changes made

items and additionalItems

dependencies

Numeric Keywords (maximum, minimum)

Also Added test cases

Uh oh!

srivastava-diya commented Jan 16, 2026

Uh oh!

jdesrosiers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

srivastava-diya commented Jan 19, 2026

Uh oh!

jdesrosiers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

srivastava-diya commented Jan 21, 2026

Uh oh!

jdesrosiers commented Jan 21, 2026

Uh oh!

jdesrosiers left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

srivastava-diya commented Jan 16, 2026 •

edited

Loading

`items` and `additionalItems`

`dependencies`

Numeric Keywords (`maximum`, `minimum`)