Skip to content

Conversation

@LordKubaya
Copy link
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@VRamakrishna VRamakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But let's treat this as a work in progress and make a refactor plan. We will need to refactor the code base to eliminate redundant proto definitions, which are currently copied over from weaver/common/protos to various packages touched in this PR. @LordKubaya Can you open an issue to track this?

"codegen": "yarn run --top-level run-s 'codegen:*'",
"codegen:proto": "yarn run proto:openapi; yarn run proto:connectrpc",
"codegen:proto": "yarn run proto:openapi; yarn clone-fabric-protos; buf generate --verbose",
"clone-fabric-protos": "rm -rf src/main/protos/fabric-protos && git clone https://github.com/hyperledger/fabric-protos.git src/main/protos/fabric-protos",
Copy link
Contributor

@sandeepnRES sandeepnRES Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using release-2.1 branch of fabric-protos repo (so as to not cause any build breaks from new changes). But if latest release is compatible, then we can use that, but I'll prefer to use some branch/tag of fabric-protos and not main branch.

Copy link
Contributor

@sandeepnRES sandeepnRES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me, just one comment I feel is important, its a small change. but you will have to test compatibility

@LordKubaya
Copy link
Contributor Author

PR looks good to me, just one comment I feel is important, its a small change. but you will have to test compatibility

Changed to release 2.1, there are no problems.

@LordKubaya
Copy link
Contributor Author

LGTM. But let's treat this as a work in progress and make a refactor plan. We will need to refactor the code base to eliminate redundant proto definitions, which are currently copied over from weaver/common/protos to various packages touched in this PR. @LordKubaya Can you open an issue to track this?

#4086

@sandeepnRES sandeepnRES self-requested a review December 4, 2025 17:37
@VRamakrishna
Copy link
Contributor

@outSH @RafaelAPB @AndreAugusto11 Can any of you review and approve so Carlos can merge this soon and move to the next task? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants