Skip to content

Fix IME composition being ignored in the first character in a line #5921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −1
Open

Fix IME composition being ignored in the first character in a line #5921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec9c2dd
Fix IME composition being ignored in the first character in a line
bibixx Jul 14, 2025
758fa3b
Add changeset
bibixx Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaggy-points-suffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'slate-react': patch
---

Fix IME composition being ignored in the first character in a line
11 changes: 10 additions & 1 deletion packages/slate-react/src/hooks/android-input-manager/android-input-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,15 @@ export function createAndroidInputManager({
insertPositionHint = false
}

if (
type === 'insertCompositionText' ||
type === 'deleteCompositionText'
) {
storeDiff(start.path, diff)
// Don't schedule selection updates during composition
return
}

if (canStoreDiff) {
const currentSelection = editor.selection
storeDiff(start.path, diff)
Expand Down Expand Up @@ -761,7 +770,7 @@ export function createAndroidInputManager({
insertPositionHint = false
}

if (pathChanged || hasPendingDiffs()) {
if ((pathChanged || hasPendingDiffs()) && !IS_COMPOSING.get(editor)) {
flushTimeoutId = setTimeout(flush, FLUSH_DELAY)
}
}
Expand Down
Loading