IBX-11038: Content rendering in BO fails after deleting user that created the content #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
|
konradoboza
reviewed
Dec 10, 2025
| { | ||
| $parameters['creator'] = null; | ||
| $ownerId = $contentInfo->getOwner()->getUserId(); | ||
| $ownerId = $contentInfo->ownerId; |
Contributor
There was a problem hiding this comment.
Did you figure out why is it different than getOwner()->getUserId()? We avoid magic whenever possible and that was also the intention behind this change. //POV ping @alongosz.
Contributor
Author
There was a problem hiding this comment.
No I didn't dig too deep, just saw we have used $contentInfo->ownerId and we don't have a getter for the ownerId either so I have just reverted to this.
Contributor
There was a problem hiding this comment.
This supposed to be an equivalent, that's why I ask. I will let Andrew give his cents though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a regression coming from #1697
authorinVersionInfomust be nullable so we can still display content of some deleted user.I have also reverted in
AuthorsTabretrievingownerIdto be directly accessed fromcontentInfoinstead of quering the owner as it might be no longer in the database.