-
Notifications
You must be signed in to change notification settings - Fork 32
Add support for custom attributes #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @spencer-cdw, thank you for raising this PR and contributing to the mq-ansible open source project. |
|
I had a look at the code and did some tests. Most of it looks good:
From the last test noticed that flag '-q' fails. This is due to -q not being the 'description' flag, but the default flag. Could either remove the funtionality or modify it? Thanks :) |
marianavillarp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flag '-q' fails. This is due to -q not being the 'description' flag, but the default flag. (copying the last comment as my review)
|
Hi @spencer-cdw, just keeping track of this PR. Thanks again for your contribution - we really appreciate it and would like to include it in the Thanks very much! |
|
Thanks for the feedback and catching that mistake. I've fixed the |
stewmcl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good
Resolves #106
AI was used in the creation of this PR, however it has been tested and is working.
Requirements.txt
Playbook