Fixed hit span for paragraph #3072
Merged
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: EmmanuelDodoo <[email protected]>
hecrj
approved these changes
Nov 29, 2025
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
I've been able to fix it while keeping the original simpler implementation.
Well, technically there is still an edge case where half a glyph won't be clickable at the end of the line. But let me sleep on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
hit_spanincorrectly handled visual breaks. Empty spaces at the end of a line were considered as part of the last span. This PR fixes it so empty spaces are ignored. The code is modified version of thespan_boundsimplementation.Before
After
