Skip to content

Conversation

@daveroga
Copy link
Contributor

  • Update contract data proofs generated
  • Fix constants needed for new stable circuits to generate data proofs properly
  • Update README with process to generate the contract data proofs

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the contract data proof generation system to support new stable circuits with different tree depth parameters. The changes include fixes to constants used for tree levels, new scripts for generating proofs with alternative circuit parameters, and updated documentation for the proof generation process.

Changes:

  • Refactored constants to support multiple circuit configurations with different tree depth parameters (introducing IssuerLevels2, ClaimLevels2, etc.)
  • Added new proof generation scripts for stable v3 circuits and v3 circuits with 16-16-64-16-32 parameters
  • Updated README with comprehensive instructions for generating contract data proofs and downloading required ptau files

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
update-contract-data/update-contract-data.js Updated relative paths to use ../ prefix for parent directory navigation
update-contract-data/update-contract-data-v3.js Updated relative paths to use ../ prefix for parent directory navigation
update-contract-data/update-contract-data-v3-stable.js New script for generating v3 stable circuit proofs using path.join with __dirname
update-contract-data/update-contract-data-v3-stable-16-16-64-16-32.js New script for generating v3 proofs with 16-16-64-16-32 parameters
testvectorgen/utils/constants.go Added new constant sets (IssuerLevels2, ClaimLevels2, etc.) for alternative circuit configurations
testvectorgen/utils/identity.go Added new methods with flexible levels parameters and updated existing methods to use new constants
testvectorgen/credentials/onchain/v3/v3_test.go Updated to use renamed constants (GistLevels → OnChainLevels, IdentityTreeLevels → IssuerLevels)
testvectorgen/contract_data/v3/v3_test.go Updated to use new MTPLevels methods and renamed constants
testvectorgen/contract_data/v3-16-16-64-16-32/v3_test.go New test file for v3 circuits with alternative tree depth parameters
testvectorgen/auth/authV3_test.go Updated constants and changed challenge value to a larger number
compile-circuit.sh Updated documentation example to reference ptau file version 18
README.md Added comprehensive documentation section for generating contract data proofs and updated ptau file references to version 18
.gitignore Changed from specific ptau file to wildcard pattern for all ptau files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant