Abstracting MathFlexOptions to EnergyBoundariesFlexOptions, integrating optimization into OptimizedFlexStrat
#1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-peter
requested review from
danielfeismann and
staudtMarius
and removed request for
danielfeismann
sebastian-peter
force-pushed
the
sp/#1572-energy-limit-optimization
branch
from
715bb5a to
10f59f6
Compare
# Conflicts: # src/test/scala/edu/ie3/simona/model/participant/PvModelSpec.scala # src/test/scala/edu/ie3/simona/model/participant/WecModelSpec.scala
danielfeismann
requested changes
Nov 6, 2025
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Some comments from my side, I'm happy to discuss them
src/main/scala/edu/ie3/simona/model/em/opt/PowerObjectiveFactory.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/ontology/messages/flex/EnergyBoundariesFlexOptions.scala
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/em/opt/OptimizedFlexStratSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/em/opt/OptimizedFlexStratSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/em/opt/OptimizedFlexStratSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/em/opt/OptimizedFlexStratSpec.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
EnergyBoundariesFlexOptions, which separates the flex options from the optimization logic.Also fixes an erroneous soft constraint penalty calculation.
Resolves #1572