Skip to content

Fixes missed export bug. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihumanable merged 7 commits into from
Jun 3, 2025
Merged

Fixes missed export bug. #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
169f434
Fixes missed export bug.
ihumanable Jun 3, 2025
f77ca60
Update the runner
ihumanable Jun 3, 2025
6de8a63
try 22.04
ihumanable Jun 3, 2025
1a69ed2
actually use ubuntu-latest
ihumanable Jun 3, 2025
7295a60
Update ci
ihumanable Jun 3, 2025
eadbc60
Remove OTP 28
ihumanable Jun 3, 2025
83d9b2b
update version matrix
ihumanable Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 5 additions & 34 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,46 +9,18 @@ on:
jobs:
build:
name: Build and test
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
matrix:
include:
- elixir-version: 1.9.4
otp-version: 20.3
- elixir-version: 1.9.4
otp-version: 21.3
- elixir-version: 1.9.4
otp-version: 22.3
- elixir-version: 1.10.4
otp-version: 21.3
- elixir-version: 1.10.4
otp-version: 22.3
- elixir-version: 1.10.4
otp-version: 23.3
- elixir-version: 1.11.4
otp-version: 21.3
- elixir-version: 1.11.4
otp-version: 22.3
- elixir-version: 1.11.4
otp-version: 23.3
- elixir-version: 1.11.4
otp-version: 24.3
- elixir-version: 1.12.3
otp-version: 22.3
- elixir-version: 1.12.3
otp-version: 23.3
- elixir-version: 1.12.3
otp-version: 24.3
- elixir-version: 1.13.4
otp-version: 22.3
- elixir-version: 1.13.4
otp-version: 23.3
- elixir-version: 1.13.4
otp-version: 24.3
- elixir-version: 1.13.4
otp-version: 25.3
- elixir-version: 1.14.5
otp-version: 23.3
- elixir-version: 1.14.5
otp-version: 24.3
- elixir-version: 1.14.5
Expand All @@ -72,12 +44,11 @@ jobs:
- elixir-version: 1.17.3
otp-version: 26.2
- elixir-version: 1.17.3
otp-version: 27.2
- elixir-version: 1.18.1
otp-version: 27.3
- elixir-version: 1.18.4
otp-version: 26.2
- elixir-version: 1.18.1
otp-version: 27.2

- elixir-version: 1.18.4
otp-version: 27.3
steps:
- uses: actions/checkout@v3
- name: Set up Elixir
Expand Down
16 changes: 6 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,16 +164,12 @@ For a guided tour and deep dive of Patch, see the [Guide Book](https://hexdocs.p

Tests automatically run against a matrix of OTP and Elixir Versions, see the [ci.yml](https://github.com/ihumanable/patch/tree/master/.github/workflows/ci.yml) for details.

| OTP \ Elixir | 1.9 | 1.10 | 1.11 | 1.12 | 1.13 | 1.14 | 1.15 | 1.16 | 1.17 | 1.18 |
|:------------:|:----:|:----:|:----:|:----:|:----:|:----:|:----:|:----:|:----:|:----:|
| 20 | ✅ | N/A | N/A | N/A | N/A | N/A | N/A | N/A | N/A | N/A |
| 21 | ✅ | ✅ | ✅ | N/A | N/A | N/A | N/A | N/A | N/A | N/A |
| 22 | ✅ | ✅ | ✅ | ✅ | ✅ | N/A | N/A | N/A | N/A | N/A |
| 23 | N/A | ✅ | ✅ | ✅ | ✅ | ✅ | N/A | N/A | N/A | N/A |
| 24 | N/A | N/A | ✅ | ✅ | ✅ | ✅ | ✅ | N/A | N/A | N/A |
| 25 | N/A | N/A | N/A | N/A | ✅ | ✅ | ✅ | ✅ | ✅ | ? |
| 26 | N/A | N/A | N/A | N/A | N/A | ✅ | ✅ | ✅ | ✅ | ✅ |
| 27 | N/A | N/A | N/A | N/A | N/A | N/A | N/A | N/A | ✅ | ✅ |
| OTP \ Elixir | 1.11 | 1.12 | 1.13 | 1.14 | 1.15 | 1.16 | 1.17 | 1.18 |
|:------------:|:----:|:----:|:----:|:----:|:----:|:----:|:----:|:----:|
| 24 | ✅ | ✅ | ✅ | ✅ | ✅ | N/A | N/A | N/A |
| 25 | N/A | N/A | ✅ | ✅ | ✅ | ✅ | ✅ | N/A |
| 26 | N/A | N/A | N/A | ✅ | ✅ | ✅ | ✅ | ✅ |
| 27 | N/A | N/A | N/A | N/A | N/A | N/A | ✅ | ✅ |

## Limitations

Expand Down
3 changes: 2 additions & 1 deletion lib/patch/mock/code/queries/exports.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ defmodule Patch.Mock.Code.Queries.Exports do
abstract_forms
|> Enum.filter(&match?({:attribute, _, :export, _}, &1))
|> Enum.reduce([], fn {_, _, _, exports}, acc ->
Keyword.merge(acc, exports)
[exports | acc]
end)
|> List.flatten()
end
end
23 changes: 23 additions & 0 deletions test/unit/patch/mock/code/queries/exports_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
defmodule Patch.Test.Unit.Patch.Mock.Code.Queries.ExportsTest do
use ExUnit.Case

alias Patch.Mock.Code.Queries.Exports

describe "query/1" do
test "handles functions with multiple arities declared across multiple exports" do
forms = [
{:attribute, 1, :export, [a: 1]},
{:attribute, 1, :export, [a: 2]}
]

expected = Enum.sort([a: 1, a: 2])

actual =
forms
|> Exports.query()
|> Enum.sort()

assert expected == actual
end
end
end