Update README instruction for engines path support #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since last version, support for Rails multi-engine setup has been included. However the README don't include instructions on how to configure it. Additionally, we have never been able to make this feature work with the old "Rails Engines support" section instructions. In this PR I propose to change this section for instructions on how to actually use the multiple `data_migrations_path` approach to get the same results with additional simplicity (you don't need to modify your engines initializers)
vprigent
approved these changes
Oct 9, 2024
vprigent
pushed a commit
to vprigent/data-migrate
that referenced
this pull request
Nov 9, 2024
* Update README instruction for engines path support Since last version, support for Rails multi-engine setup has been included. However the README don't include instructions on how to configure it. Additionally, we have never been able to make this feature work with the old "Rails Engines support" section instructions. In this PR I propose to change this section for instructions on how to actually use the multiple `data_migrations_path` approach to get the same results with additional simplicity (you don't need to modify your engines initializers) * Keep previous folder name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since last version, support for Rails multi-engine setup has been included. However the README don't include instructions on how to configure it.
Additionally, we have never been able to make this feature work with the old "Rails Engines support" section instructions.
In this PR I propose to change this section for instructions on how to actually use the multiple
data_migrations_pathapproach to get the same results with additional simplicity (you don't need to modify your engines initializers)