Fix translation of literal 0 in function pointer assignment/comparison #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds LIT checks for a few existing cases at the top and some new tests. The two LIT checks at the bottom are valid code, but I'm not sure if that's the simplest way to rewrite that.
Contributor
Author
|
Woops, tests were failing because I didn't realize I needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #438 to fix cases where the rewriter was generating invalid code when assigning 0 to a function pointer or when comparing a function pointer against 0. This fixes #412.
@ayrtonm This doesn't fully address #411 (which you were trying to do in the original PR), but I'm having a harder time getting that working. Does it make sense to you to land this portion of the changes on its own?