Fixed to handle Union of datasources and date as column 1#21
Open
jyshekhar-git wants to merge 1 commit intoimplydata:mainfrom
Open
Fixed to handle Union of datasources and date as column 1#21jyshekhar-git wants to merge 1 commit intoimplydata:mainfrom
jyshekhar-git wants to merge 1 commit intoimplydata:mainfrom
Conversation
Author
|
Reason for the change is because the ['query'] in the code was throwing an error of the type: Also added code for groupBy |
Collaborator
|
Hi @jyshekhar-git - thanks for the PR - I don't think we want to keep changing the code each time a customer has a different log format... I think it might be better if we make it an option? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified code to fix bug to handle union.
original json file had something like:
queryId = query['query']['context']['queryId']
Modified the code to remove this and all instances of ['query']