IWF-836: SDK expects stateWaitUntilFailed flag instead stateStartApiSucceeded #112
Conversation
| @@ -0,0 +1,23 @@ | |||
| #! /usr/bin/env bash | |||
|
|
|||
| gsed -i'' \ | |||
There was a problem hiding this comment.
@N-give I did have to use gsed in the end here. The output of the script locally was different than the one in the CI, gsed fixes that: https://github.com/indeedeng/iwf-python-sdk/actions/runs/15640692181/job/44067031610
I'll create a quick PR to update it in the samples repo too
There was a problem hiding this comment.
I can't follow the functions so I used LLM to explain them
could you add a comment at the top of the file to explain why we need it and what it is doing?
There was a problem hiding this comment.
Added now:
# This script ensures that the poetry.lock file does not contain references to the internal Indeed Nexus PyPI repository.
# It is used as a git hook to automatically remove the [package.source] section for Nexus from poetry.lock.
# This is necessary to ensure the lock file is portable and open-source friendly.
# The script uses gsed to remove the Nexus source block and any resulting empty lines, then checks if any changes were made.
# If Nexus references are found and removed, the script exits with 1 to prevent the commit, so we can stage the changes made by the script before committing again.
| timer_commands: list[TimerCommandResult] | ||
| internal_channel_commands: list[InternalChannelCommandResult] | ||
| signal_channel_commands: list[SignalChannelCommandResult] | ||
| wait_until_api_succeeded: Optional[bool] = None |
There was a problem hiding this comment.
I added this to match the properties in the CommandResults class in Java SDK: https://github.com/indeedeng/iwf-java-sdk/blob/main/src/main/java/io/iworkflow/core/command/CommandResults.java#L17-L23
And to be able to also implement the same exact logic using wait_until_api_succeeded
Description
SDK expects stateWaitUntilFailed flag instead stateStartApiSucceeded
Checklist
Related Issue
Addressing, but not yet closing indeedeng/iwf#520, as we still need: