Skip to content

Conversation

@ktrops
Copy link
Contributor

@ktrops ktrops commented Oct 17, 2025

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #issue_number

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.84%. Comparing base (fb741d0) to head (e61a247).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
service/interpreter/workflowImpl.go 90.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   66.35%   65.84%   -0.51%     
==========================================
  Files          65       64       -1     
  Lines        7564     6433    -1131     
==========================================
- Hits         5019     4236     -783     
+ Misses       2220     1872     -348     
  Partials      325      325              
Files with missing lines Coverage Δ
service/interpreter/globalVersioner.go 88.88% <100.00%> (-0.86%) ⬇️
service/interpreter/workflowImpl.go 86.77% <90.00%> (+1.31%) ⬆️

... and 56 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

const SyncUpdateRPCUseLocalActivity = 9

const MaxOfAllVersions = SyncUpdateRPCUseLocalActivity
// StartingVersionWaitingCommandThreads Wait for all command threads to complete before taking a snapshot, so that commands don't get lost with continue as new.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@ktrops ktrops merged commit 45f9e43 into main Oct 29, 2025
10 checks passed
@ktrops ktrops deleted the jira/katiea/IWF-1133 branch October 29, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants