- 
                Notifications
    
You must be signed in to change notification settings  - Fork 57
 
IWF-1133: fix threading with continue as new #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   66.35%   65.84%   -0.51%     
==========================================
  Files          65       64       -1     
  Lines        7564     6433    -1131     
==========================================
- Hits         5019     4236     -783     
+ Misses       2220     1872     -348     
  Partials      325      325              
 🚀 New features to boost your workflow:
  | 
    
| const SyncUpdateRPCUseLocalActivity = 9 | ||
| 
               | 
          ||
| const MaxOfAllVersions = SyncUpdateRPCUseLocalActivity | ||
| // StartingVersionWaitingCommandThreads Wait for all command threads to complete before taking a snapshot, so that commands don't get lost with continue as new. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Description
Checklist
Related Issue
Closes #issue_number