Refactor evaluating string fields #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Dec 17, 2024
inducer
reviewed
Dec 17, 2024
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! Just a few minor nits/questions, but generally LGTM!
arraycontext/container/dataclass.py
Outdated
Comment on lines
109
to
112
| if __debug__: | ||
| # NOTE: this should never happen due to using `inspect.get_annotations` | ||
| if isinstance(field_type, str): | ||
| raise TypeError(f"String annotation on field '{f.name}' not supported.") |
Owner
There was a problem hiding this comment.
Suggested change
| if __debug__: | |
| # NOTE: this should never happen due to using `inspect.get_annotations` | |
| if isinstance(field_type, str): | |
| raise TypeError(f"String annotation on field '{f.name}' not supported.") | |
| assert not isinstance(field_type, str) |
?
Collaborator
Author
There was a problem hiding this comment.
alexfikl
force-pushed
the
refactor-dataclass-types
branch
from
c44687e to
f705a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating inducer/boxtree#56 and noticed that it also needs to handle string annotations, but with a slightly different
is_array_fieldpredicate.This refactors the
get_annotationslogic into a separate function so that it can be reused.