use pymbolic's cached mappers #321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
reviewed
May 13, 2022
Comment on lines
+33
to
38
| from pymbolic.mapper.substitutor import (CachedSubstitutionMapper as | ||
| SubstitutionMapperBase) | ||
| from pymbolic.mapper.dependency import (DependencyMapper as | ||
| from pymbolic.mapper.dependency import (CachedDependencyMapper as | ||
| DependencyMapperBase) | ||
| from pymbolic.mapper.evaluator import (EvaluationMapper as | ||
| from pymbolic.mapper.evaluator import (CachedEvaluationMapper as | ||
| EvaluationMapperBase) |
Owner
There was a problem hiding this comment.
Could you change the imported names to include Cached, to avoid misunderstandings?
| from typing import ( | ||
| Any, Union, Mapping, FrozenSet, Set, Tuple, Optional, TYPE_CHECKING) | ||
|
|
||
| from pymbolic.mapper import (WalkMapper as WalkMapperBase, IdentityMapper as |
Owner
There was a problem hiding this comment.
Could you characterize the impact of this PR? Any notable compile time improvements? Did anything get worse?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: kaushikcfd#3