Skip to content

Add request lifecycle diagram #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add request lifecycle diagram #290

wants to merge 2 commits into from

Conversation

@skryukov
Copy link
Collaborator

@skryukov skryukov commented Nov 22, 2025 •
edited
Loading

  • Added a new "Request lifecycle diagram" section with a visual diagram
  • Updated the page object documentation to include more detailed descriptions
  • Revised and expanded example page objects to consistently include the errors property

@BrandonShar
Copy link
Collaborator

BrandonShar commented Nov 23, 2025

What are you thoughts on changing "Returns HTML skeleton" to something referencing that it returns the inertia ERB along with props/view vars? I think that makes it a bit more clear what's happening in a literal sense (which seems to be what we're targeting with the diagram)

@skryukov
Copy link
Collaborator Author

skryukov commented Nov 23, 2025 •
edited
Loading

It can go either way, but I wonder if ERB part is too specific for "the protocol" page 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skryukov @BrandonShar