Don't crash when no database connection is present #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- N/a # Describe the changes made. What does this PR changes that might be critical. If any critical decisions have been made, make sure you explain the rationale for these decisions. - Updated JRuby minor version to fix some tests - Updated travis.yml to latest syntax - Fixed Rakefile to run in rails 6 - Updated gemspec to have URLs matching # How does the implementation addresses the problem After merging this all test suite for apartment gem is passing using rails 6.
…sage - Fixes CI runs: - One of the rails versions [had a bug](rails/rails#38137) and causes the CI to fail. I've moved it to the allowed failures. - I think we should deprecate these versions as they are EOL. => New ticket to be created - Fixes rubocop installation - I had not realized when I merged rubocop installation that I was breaking all CI (I'm sorry for the rushed decision). This fixes the dependencies and all CI should be passing. - Adds rubocop to github actions. All the rubocop failures will be fixed with influitive#8
[Resolves influitive#9] Cleanup rubocop todo
…-config-to-only-run-pr-s-in-12 [Resolves influitive#12] Update travis config to only run PRs instead of all commits - Updated travis.yml to run only for branches: `master` and `development`. - Due to the nature of PRs, nothing needs to be done to ensure tests run against an open PR
victorhazbun
reviewed
Apr 8, 2025
| end | ||
| rescue ::ActiveRecord::NoDatabaseError | ||
| # rubocop:disable Lint/SuppressedException | ||
| rescue ::ActiveRecord::NoDatabaseError, PG::ConnectionBad |
There was a problem hiding this comment.
This is supposed to be the fix, correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #607 and seems to be related to #589 and #608.