chore(misc): Merge PR's from upstream #21
Merged
+1,754
−983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted messages (circlefin#1189) After circlefin#1185, the `GetValidator` effect is not necessary anymore since we will only ever verify signatures for messages at the current height. We can therefore remove it, alongside the corresponding `AppMsg` and `HostMsg` variant, and with them a potential footgun for integrators.
…rclefin#1205) use managed action for `amannn/action-semantic-pull-request`
…irclefin#1215) Since the `Consensus` actor will block on the reply to the underlying `HostMsg::StartedRound`, it won't be processing any other message until the app returns a reply, so there won't any other message for the app to process either.
…ipating in consensus (circlefin#1174) Closes: #XXX Adds new Sync-Only mode for Full Nodes Behavior: - Subscribes only to sync network topics - Downloads and validates blocks - Does not process consensus messages (proposals, votes, certificates) - Does not participate in voting or proposal validation Use Cases: - Block explorers, read-only applications, archival nodes - Validators that are far behind - The UX is not great: starts with `consensus.enable=false`, when close to the tip, the validator needs to be manually restarted with updated config: `consensus.enable=true` - For this use case we should have config reload or even better rejoining consensus when getting close to the tip --- - [ ] Reference a GitHub issue - [ ] Ensure the PR title follows the [conventional commits][conv-commits] spec - [ ] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [ ] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]>
Closes: #XXX --- ### PR author checklist #### For all contributors - [ ] Reference a GitHub issue - [ ] Ensure the PR title follows the [conventional commits][conv-commits] spec - [ ] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [ ] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it #### For external contributors - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests
…circlefin#1198) Closes: #XXX Full nodes fail to resume syncing after validator network restarts. Similarly a validator node not included in persistent peers of the restarting set is affected for both consensus and sync. --- - [ ] Reference a GitHub issue - [ ] Ensure the PR title follows the [conventional commits][conv-commits] spec - [ ] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [ ] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests --------- Co-authored-by: Romain Ruetschi <[email protected]>
…#1226) Closes: #XXX Consensus requests can fail for 3 reasons: - The request channel has been closed (typically because consensus has stopped) - The request channel is full (more requests than consensus can process, current buffer size is `100`) - The response cannot be received (consensus went down before sending a reply or something else went wrong) This PR adds `ConsensusRequestError` enum to encode each different type of failure and changes the `ConsensusRequest::dump_state` method to return a `Result`. --- ### PR author checklist #### For all contributors - [ ] Reference a GitHub issue - [ ] Ensure the PR title follows the [conventional commits][conv-commits] spec - [ ] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [ ] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it #### For external contributors - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests
…fin#1216) Closes: #XXX The Rust code of conduct link was wrong. So I opened pull request for fixing the link. --- ### PR author checklist #### For all contributors - [ ] Reference a GitHub issue - [ ] Ensure the PR title follows the [conventional commits][conv-commits] spec - [ ] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [ ] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it #### For external contributors - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests Co-authored-by: Romain Ruetschi <[email protected]>
Closes: #XXX --- ### PR author checklist #### For all contributors - [ ] Reference a GitHub issue - [ ] Ensure the PR title follows the [conventional commits][conv-commits] spec - [ ] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [ ] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it #### For external contributors - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests
…essing `StartHeight` input (circlefin#1233) Closes: circlefin#1232 **Story:** <https://circlepay.atlassian.net/browse/CCHAIN-578> --- ### PR author checklist #### For all contributors - [x] Reference a GitHub issue - [x] Ensure the PR title follows the [conventional commits][conv-commits] spec - [x] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [ ] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it #### For external contributors - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests
This is a historical acknowledgement & a hat-tip to the Shielded Labs team, with whom we collaborated in the past. It was an oversight on my part that we had not included this team in the Ack section before. --- ### PR author checklist #### For all contributors - [ ] Reference a GitHub issue - [ ] Ensure the PR title follows the [conventional commits][conv-commits] spec - [ ] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [ ] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it #### For external contributors - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests
… signer implementations (circlefin#1191) Closes: #XXX --- - [x] Introduce `malachitebft-signing` crate for exposing the `SigningProvider` and `SigningProviderExt` traits - [x] Make methods of `SigningProvider` and `SigningProviderExt` traits fallible - [ ] Reference a GitHub issue - [x] Ensure the PR title follows the [conventional commits][conv-commits] spec - [x] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [x] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests
* `arduino/setup-protoc` * `katyo/publish-crates`
Author
|
The failing test is probably related to: circlefin@b31e2ff @insumity . |
…uest (circlefin#1205)" This reverts commit 72f3bba.
)" This reverts commit b95f1a3.
insumity
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #20
This PR merges all the PRs from the malachite repo between September 16th 2025 and October 16th 2024 in circlefin except circlefin#1211 and circlefin#1230 and circlefin#1222 . These two reactors change the value sync reactor too much and will be done separately.
PR author checklist
For all contributors
RELEASE_NOTES.mdif the change warrants itBREAKING_CHANGES.mdif the change warrants itFor external contributors