chore(misc): Merge PR's from upstream #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 3bd9b68)
Closes: #XXX Story: https://circlepay.atlassian.net/browse/CCHAIN-602 --- - [ ] Reference a GitHub issue - [ ] Ensure the PR title follows the [conventional commits][conv-commits] spec - [ ] Add a release note in [`RELEASE_NOTES.md`](/RELEASE_NOTES.md) if the change warrants it - [ ] Add an entry in [`BREAKING_CHANGES.md`](/BREAKING_CHANGES.md) if the change warrants it - [ ] Maintainers of Malachite are [allowed to push changes to the branch][gh-edit-branch] [conv-commits]: https://www.conventionalcommits.org/en/v1.0.0/#summary [gh-edit-branch]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests (cherry picked from commit b205f42)
insumity
force-pushed
the
insumity/cherry-pick-sync-related-commits
branch
from
4014bf5 to
4de3493
Compare
jmalicevic
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bring
circlefin/malachite's PRs #1211 and #1230 into this repo.Note that from #1211 we only brought the single commit that introduces a test in
value_sync.rs. This is because, we already have introduced a new way of syncing in #15 (e.g., withoutsync_height) and #1211 changes do not apply here.PR author checklist
For all contributors
RELEASE_NOTES.mdif the change warrants itBREAKING_CHANGES.mdif the change warrants itFor external contributors