[common] Update manifest role and config #279
Conversation
elfiesmelfie
requested review from
ayefimov-1,
lnatapov,
mgirgisf,
myadla and
vyzigold
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7bfdec45f3ff4ee8af74b63280096267 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 06s |
elfiesmelfie
force-pushed
the
efoley/update_manifest_tests
branch
from
5b6e3ac to
86adbaa
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/87925265dc11473dad903dbaff8759a2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 52m 14s |
* Use a list of strings, instead of a space-separated string * Remove the string separating tasks * Replace `wc -l` with stdout_lines | length * Name the loop var
Run the oc command just once to get the package manifet list, and then compare the expected packages to this static list. This reduces the test runtime by returning all the needed information once, instead of running getting the information for each comparison.
elfiesmelfie
force-pushed
the
efoley/update_manifest_tests
branch
from
86adbaa to
96e817d
Compare
Change common_manifest_list from list-of-lists to list-of-dictionaries with 'name' and 'expected_number' keys. The expected_number key is optional and defaults to 1 when not specified. Refactored manifest_tests.yml to use block-level variables for expected_count and actual_count to eliminate repetitive filter expressions and improve readability. Updated documentation in README.md to reflect the new structure and provide usage examples. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
elfiesmelfie
dismissed stale reviews from ayefimov-1 and vyzigold
There have been big changes since the review was made
wc -lwith stdout_lines | length