Skip to content

Conversation

@Schwehn42
Copy link
Member

Description

Closes #5420

Streamlines keyboard interaction with column name/description editing using the template editor and the board (#5401)

  • enter to save changes
  • shift+enter for newline in textarea component
  • escape to cancel changes

Changelog

  • ColumnConfiguratorColumnNameDetails: adjusts key binds to save/cancel changes
  • change blur mechanic from individual inputs to useOnBlur hook
  • adjust test

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Schwehn42 Schwehn42 self-assigned this Oct 9, 2025
@Schwehn42 Schwehn42 linked an issue Oct 9, 2025 that may be closed by this pull request
@Schwehn42 Schwehn42 changed the title feat: configurator column keyboar navigation improvement: configurator column keyboard navigation Oct 10, 2025
Copy link
Collaborator

@BingeCode BingeCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just a few minor things I noticed:

  • PR title needs to be changed to align with Contributing.md semantic titles, maybe something like "feat: Improved keyboard navigation in Template columns"
  • Escape doesn't register on the onkeydown event on my machine (in any browser), only onkeyup. Does it work for you?

@BingeCode BingeCode changed the title improvement: configurator column keyboard navigation feat: Improved keyboard navigation in template columns Oct 28, 2025
@BingeCode BingeCode added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@github-actions
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://5500.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-58ff11b

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-58ff11b

@BingeCode BingeCode added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit e538e20 Oct 29, 2025
19 checks passed
@BingeCode BingeCode deleted the js/template-configurator-column-keyboar-nav branch October 29, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keyboard navigation for template configurator column

3 participants