Merged
Conversation
Melkiades
reviewed
Feb 3, 2026
Melkiades
approved these changes
Feb 3, 2026
Contributor
Melkiades
left a comment
There was a problem hiding this comment.
Remember NEWS file and it is good to go for me! Great thing. I would keep it as an optional customization (to add to the customization stack in the catalog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_with_rmarkdown, improving reliability when working with different table types (especiallygt_tbl). It introduces a new helper function to distinguish between generic lists and special table objects, and updates documentation and tests to cover new usage patterns.Refactoring and Logic Improvements:
is_simple_list()helper function to reliably distinguish between generic lists and special table objects likegt_tbl, replacing previous directinherits(x, "list")checks throughout the codebase. (R/save_with_rmarkdown.R,R/create_yaml_header.R) [1] [2] [3] [4] [5]save_with_rmarkdown()andcreate_yaml_header()to useis_simple_list()for more accurate handling of input objects, ensuring correct processing of lists and single table objects. (R/save_with_rmarkdown.R,R/create_yaml_header.R) [1] [2] [3] [4]Documentation Enhancements:
flextableandgttables, reflecting new usage patterns enabled by the refactor. (R/save_with_rmarkdown.R,man/save_with_rmarkdown.Rd) [1] [2]Testing Improvements:
save_with_rmarkdown()works correctly with lists ofgt_tblobjects, verifying that output files are created as expected. (tests/testthat/test-save_with_rmarkdown.R)