Open
Conversation
Contributor
Code Coverage SummaryDiff against mainResults for commit: b6c26c4 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 25 suites 6s ⏱️ Results for commit b6c26c4. ♻️ This comment has been updated with latest results. |
llrs-roche
reviewed
Feb 13, 2026
Contributor
llrs-roche
left a comment
There was a problem hiding this comment.
I am not sure what are the lintr issues identified on column_functions.R but I think we could make it more readable and at the same time pass the lintr
Co-authored-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com> Signed-off-by: Oriol Senan <35930244+osenan@users.noreply.github.com>
Contributor
Author
|
The issues were the line length. I tried to break the line and then the sytler bot was changing the line. Then the linter was failing again. That is why I decided to apply a small refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two lintr errors from previous PR that were not fixed. This PR keeps the linter clean to have passing CI. To review it, check that all CI is passed.