feat(actions_permissions): sha_pinning_required #2870
+48
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonard Sheng Sheng Lee <[email protected]>
sheeeng
force-pushed
the
feat/actions_permissions_sha_pinning_required
branch
from
6289202 to
49ad201
Compare
nickfloyd
requested changes
Nov 10, 2025
| github.com/golangci/unconvert v0.0.0-20240309020433-c5143eacb3ed // indirect | ||
| github.com/google/go-cmp v0.6.0 // indirect | ||
| github.com/google/go-cmp v0.7.0 // indirect | ||
| github.com/google/go-github/v78 v78.0.0 // indirect |
Contributor
There was a problem hiding this comment.
Unfortunately this provider is on v67 and the upgrade has not been made to get us to v78 yet.
Author
There was a problem hiding this comment.
@nickfloyd, thanks for the review. 🙇
Shall I keep this PR open while waiting for it to be upgraded?
Contributor
There was a problem hiding this comment.
Yeah, let's do that... I'm hopeful we'll make some good progress getting there. This is the batch where we are tracking that, please feel free to take on any of the version bumps.
We are currently trying to move toward v68 - but the breaking changes in that one are significant - all of the old project APIs were removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until google/go-github#3807 is being included in the next release.Resolves #2869.
Before the change?
sha_pinning_requiredoption for actions permissions is not supported.After the change?
sha_pinning_requiredoption actions permissions is supported.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!