Skip to content

Various fixes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
clementFoyer wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Various fixes #16

clementFoyer wants to merge 10 commits into from

Conversation

@clementFoyer
Copy link

@clementFoyer clementFoyer commented Oct 24, 2023 •
edited
Loading

  • Add various small modifications (adding some override to explicit the virtual nature of these functions)
  • Resolve some memory leaks for memkind-pmem allocator
  • Simplify statistics management and reduce code duplication
  • Unify the codes for allocator's header computation
  • Add a new option (and environment variable) to specify the base in which the integer have to be read. This is useful when some software export the stack offset as hexadecimal value, while other export it as decimal.
  • When the library fails and call exit or _exit, an error code value is returned.
  • Add do-while(0) to scope macros and avoid potential errors
  • Allow the use of a user configured base when parsing input location file : the offset may be given either in decimal or hexadecimal (or any base, really, to fit with the input)
  • Unify the use of environment variable by putting all that management in common.cxx

@clementFoyer clementFoyer mentioned this pull request Nov 9, 2023
Open
@clementFoyer clementFoyer force-pushed the various-fixes branch 5 times, most recently from 0794c93 to 4e09aef Compare January 19, 2024 16:42
@clementFoyer
Add "do-while(0)" statement to #define preprocessing macros
56b78f4 
Without the protection of the do-while statement, some instructions may
not be well handled by the compiler in cases of "if" statements with
curly brackets for example.
@clementFoyer clementFoyer force-pushed the various-fixes branch 3 times, most recently from bc77062 to efbc2d5 Compare January 19, 2024 17:08
@clementFoyer
Use user-defined base value for strtoull
9672df1 
  * Use size_t instead of unsigned long/unsigned long long.
@clementFoyer
Return error value when exiting on error
607fa10
@clementFoyer
Use a variable set once to define the output stream in `CodeLocations…
3c37ae5 
…::show_hmem_visualizer_stats`
@clementFoyer
Simplifying the fallback allocator process
169de2b
@clementFoyer
Use options to handle the configuration from env
f18f666 
Setting the fallback allocator, min size fallback allocator, locations
and definitions in options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@clementFoyer