[SYCL][LIT] Re-enable Windows ABI check test #21028
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables the Windows ABI check test that was previously disabled due to issue #20915. The changes address ABI compatibility by modifying the device class constructors and updating the expected Windows symbol dump to reflect simplified setNDRangeDescriptor overloads.
Changes:
- Re-enabled Windows ABI check test by removing the UNSUPPORTED directive
- Changed
devicecopy and move constructors from defaulted to explicitly declared - Updated Windows symbol dump to reflect consolidated
setNDRangeDescriptorsignatures
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sycl/test/abi/sycl_symbols_windows.dump | Removed UNSUPPORTED directive, updated symbol signatures for setNDRangeDescriptor methods, and removed trailing blank line |
| sycl/source/device.cpp | Added explicit definitions for copy and move constructors |
| sycl/include/sycl/device.hpp | Changed copy and move constructor declarations from defaulted to explicitly declared |
againull
approved these changes
Jan 10, 2026
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20915
Post-commit run: https://github.com/intel/llvm/actions/runs/20870081312