Skip to content

Conversation

@Anjali-Khantaal
Copy link
Collaborator

Summary

Standardized Slurm scripts to have consistent variable names and commands, making them easier to read; and updated juwels config parameters like date window, sequence length, and downsampling fraction


@Anjali-Khantaal Anjali-Khantaal requested a review from lineick August 5, 2025 12:56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not push your current configs if you just changed vars, otherwise each config has different vals

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgit that comment i think

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was as an advice for the future. What did I do wrong here? I am sorry, I didn't understand.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove please, i removed it before in your branch, but somehow it got added again

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also update vega and lumi runall and slurm in the same PR otherwise there functionality diverges

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as before I commited on your branch with those removed, now they appeared again apparently

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still here

Copy link
Collaborator

@lineick lineick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, if you resolved comments, you can close them by clicking on resolve conversation so it does not get crowded

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgit that comment i think

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test this on lumi? making sure it works with hython

Copy link
Collaborator Author

@Anjali-Khantaal Anjali-Khantaal Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have access to lumi yet

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants