fix: the value of warcVer changed unexpectedly
#154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lifecycle of warcVer spans multiple `readUntilDelim()` calls, and changes in the underlying buffer (intermediateBuf) data can cause unexpected to the warcVer.
equals215
approved these changes
Nov 1, 2025
Collaborator
|
Is this covered in #150? Also are there WARC integrity concerns here? |
Collaborator
Author
Ah, indeed covered, I didn't notice that. This only causes the warcVer to become random data, and then our |
Collaborator
Author
|
Wait, this is a bug fix PR, while #150 is a feature PR. How about merging this small PR first? :) |
Member
|
Good news that the WARC integrity is unaltered by this bug. I'm in favor of merging the bugfix first, and fast |
Collaborator
|
That works with me. Thanks for the answers and as always appreciate it! |
NGTmeaty
approved these changes
Nov 3, 2025
Collaborator
|
And I pushed a new release 😄 |
Copilot AI
pushed a commit
that referenced
this pull request
Nov 15, 2025
The lifecycle of warcVer spans multiple `readUntilDelim()` calls, and changes in the underlying buffer (intermediateBuf) data can cause unexpected to the warcVer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: the lifecycle of
warcVerspans multiplereadUntilDelim()calls, and changes in the underlying buffer (intermediateBuf) data cause unexpected changes to the warcVer.