-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: mobile dropdown cell height #11477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mobile dropdown cell height #11477
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves mobile usability by adding touch-friendly styles to dropdown elements and form controls, ensuring consistent minimum heights and padding on devices with coarse pointers (touch screens).
- Adds
@media (pointer: coarse)queries withmin-height: 44pxto meet touch target accessibility guidelines - Applies consistent padding to autocomplete dropdowns, form inputs, and select elements for better touch interaction
- Targets specific elements: form inputs/selects in page-edit, autocomplete list items and language options, and olform select elements
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| static/css/page-edit.less | Adds touch-friendly padding and min-height to form inputs and select elements on touch devices |
| static/css/components/jquery.autocomplete.less | Increases padding and sets min-height for autocomplete dropdown items and language selections on touch devices |
| static/css/components/form.olform.less | Adds touch-specific styles to select elements within olform, but contains a syntax error with missing line break |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
for more information, see https://pre-commit.ci
…, and input sizing
for more information, see https://pre-commit.ci
|
@jimchamp I tried to fix it, but there might be multiple issues. PTAL and suggest how I can fix them. |
|
Thanks @akramcodez. I can sort of understand why you changed all of the form The only thing in scope for this PR is the language auto-complete options. Please revert all other unrelated changes. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @media (pointer: coarse) { | ||
| padding: 12px 5px; | ||
| min-height: 44px; | ||
| } | ||
| } |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The padding is being applied to the inner .ac_language div, but the parent li element (line 22) already has padding: 5px. This could result in inconsistent spacing. Consider applying the touch target styles directly to the li element using a selector like .ac_results li:has(.ac_language) or applying the styles to .ac_results li with the media query and removing padding from the inner div to avoid double padding.
| @media (pointer: coarse) { | |
| padding: 12px 5px; | |
| min-height: 44px; | |
| } | |
| } | |
| @media (pointer: coarse) { | |
| // Move touch target padding/min-height to parent li to avoid double padding | |
| // Remove padding from .ac_language | |
| } | |
| // Apply touch target styles to li containing .ac_language for coarse pointers | |
| @media (pointer: coarse) { | |
| .ac_results li:has(.ac_language) { | |
| padding: 12px 5px; | |
| min-height: 44px; | |
| } | |
| } | |
| } |
|
@jimchamp I’m a bit confused here. I’ve reverted the mistakes, should I implement the Copilot suggestion? |
|
If copilot told you to jump off of a cliff, would you do it? You fixed the issue. The other autocomplete options are already large enough on smaller screens. |
Closes #11182
This PR ensures that dropdown rows (such as for languages and contributor roles) in forms and autocomplete menus have consistent height and padding across all devices, especially improving usability on touch devices like mobile and tablets. It increases the minimum height and padding on touch screens to make selection easier and more accessible.
Technical
Testing
Screenshot
Stakeholders
@jimchamp