Fix Sentry profiling by adding continuous profiling support #11495
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves internetarchive#11493 This change updates the Sentry configuration to support continuous profiling, which is required for Sentry SDK versions 2.24.1 and later. Changes: - Added profile_session_sample_rate parameter to enable continuous profiling - Added profile_lifecycle parameter set to 'trace' mode for automatic profiling - Updated both openlibrary.yml and coverstore.yml configuration files - Maintained backward compatibility by keeping existing profiles_sample_rate The old transaction-based profiling (profiles_sample_rate) has been deprecated in favor of continuous profiling. This fix ensures profiling data is properly collected and sent to Sentry.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11493 - Sentry profiling not working in production
This PR adds support for Sentry's continuous profiling, which is required for SDK versions 2.24.1 and later. The old transaction-based profiling approach using only
profiles_sample_ratehas been deprecated.Changes Made
profile_session_sample_rateparameter to enable continuous profilingprofile_lifecycleparameter set to'trace'mode for automatic profiling with active spanssentry_sdk.init()profiles_sample_rateTechnical Details
According to Sentry's documentation, continuous profiling requires:
profile_session_sample_rate- Must be non-zero to enable continuous profilingprofile_lifecycle- Set to'trace'for automatic profiling with spansThe current SDK version (2.19.2) supports this configuration, and it will work with future updates.
Related Issues
Closes #11493