Skip to content

Conversation

@isc-bsaviano
Copy link
Contributor

  • Fixes Bug: server side search misses searching class member definitions #1480
  • Report search matches in the ROUTINE header and non-description comments in the class definition.
  • Improve conversion of include and exclude glob arrays to regular expressions.
  • Create an enum of supported isfs query parameters and a new helper method for getting the isfs display configurations from query parameters in a Uri. This significantly reduces the use of “magic strings”.
  • Create new helper method for getting the name of a document from an isfs Uri.
  • Create new helper method for creating a fuzzy match string to be used with the SQL LIKE predicate. Currently used to find workspace symbols and files.
  • Use new workspace connection picker for project commands.
  • Improve source control action picker prompts (see 'Server Source Control' and 'Server Command Menu' flipped after connecting to different server #1458)
  • Re-write queries for discovering server-side unit tests to improve performance.
  • Always hide .bpl and .dtl files since users can’t edit them.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good based on code-reading. A couple of nits picked. I will install the dev VSIX and see if I spot any problems in daily use.

@isc-bsaviano
Copy link
Contributor Author

Thanks John!

@gjsjohnmurray gjsjohnmurray self-requested a review February 24, 2025 16:45
@isc-bsaviano isc-bsaviano merged commit 5f7402d into intersystems-community:master Feb 24, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the server-side branch February 24, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: server side search misses searching class member definitions

2 participants