-
Notifications
You must be signed in to change notification settings - Fork 29
Turn module into generic VCS plugin #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a global variable capture issue making the menu fail to differentiate between provider items
Member
Author
|
This PR has been split into multiple smaller and easier-to-review chunks. Please see #188 for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
Closes #189
Closes inveniosoftware/invenio-oauthclient#353
Description
Changes this module into a new generic plugin for any Version Control System (VCS).
Renamed module to
invenio_vcs. This is open to discussion and I'm happy to choose another name or even keep the existing one if we decide the migration would be too difficult.Full description coming soon
This is a WIP and not all features are implemented yet. In particular:
info_serializerhandler ininvenio.cfg. See the example for CDS: feat(vcs): support for new VCS integration CERNDocumentServer/cds-rdm#554vcs_repositoriestable instead of the OAuth remote userextra_datafield.extra_datatoJSONBinvenio-oauthclient#360Upcoming features
We will merge this PR when:
However, the following features will only be implemented in a future PR: