dropdown: enable mutliple selection by default #320
Conversation
jrcastro2
commented
Dec 4, 2025
jrcastro2
commented
- Adds support and default implementation for multiple selection
- closes 1 - Enhance e-mail notifications CERNDocumentServer/cds-rdm#628
jrcastro2
force-pushed
the
improve-dropdown
branch
from
7d88453 to
12760f0
Compare
| import { FeedbackLabel } from "../forms/FeedbackLabel"; | ||
|
|
||
| export class SelectField extends Component { | ||
| constructor(props) { |
There was a problem hiding this comment.
not sure I understand why we need to add state management for this component, could you explain me?
There was a problem hiding this comment.
Sure! We need to add the options to the state because now they are not static only. On a traditional SelectField you would pass the options before (such as vocabularies) but now for the emails for example we want to allow to add new values on the SelectField, to display these values we need to add them to the options as well alongside to the already default static ones passed, otherwise they will not show in the field itself. And also we need it to update the options as we add new items to it manually.
There was a problem hiding this comment.
we were already able to add new options in the keyword field (deposit form), can't we use the same component, instead of changing the select? I think Select is specifically done so you can select from an existing list, not to add new ones
It would be better to avoid complex component, and have them handle a single responsibility
* Adds support and default implementation for multiple selection * closes CERNDocumentServer/cds-rdm#628
jrcastro2
force-pushed
the
improve-dropdown
branch
from
12760f0 to
ab2ea93
Compare
2 participants
