-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(model manager): 💄 refactor model manager bulk actions UI #8684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(model manager): 💄 refactor model manager bulk actions UI #8684
Conversation
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works very well.
However, there is a minor aesthestic issue that needs to be fixed. In the current main branch, the model type headings (e.g. "Main") have a higher z-level than the model names and thumbnails as shown here:

In the PR, the positions are reversed, so that the model names and thumbnails obscure the model type headings:

|
I just noticed an additional issue. The translation string for ModelManager.selectAll seems to be missing. |
|
@lstein Fixed the overlapping issue, however the |
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working as advertised.
Summary
Redesigns the Model Manager's bulk actions UI for a more seamless and smooth integration.
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)