Adding QR and CAE for Argentina #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for Argentina's ARCA (AFIP) tax authority requirements by implementing QR code and CAE (Comprobante de Autorización Electrónico) display functionality. The changes also refactor country code comparisons across the codebase to use a more consistent API pattern.
Key changes include:
- New Argentina regime component with ARCA QR code and CAE display template
- Refactored country code comparison from
CountrytoCountry.Code()for consistency - Added exemption column to Spanish invoice HTML outputs
- Local GOBL dependency replacement for development
Reviewed changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| goblhtml.go | Updated Portuguese country check to use Country.Code() method |
| go.mod | Added local GOBL dependency replacement directive |
| go.sum | Removed GOBL v0.301.0 checksum entries due to local replacement |
| components/regimes/pt/pt.go | Refactored country code comparison to use Country.Code() |
| components/regimes/gr/gr.go | Refactored country code comparison to use Country.Code() |
| components/regimes/ar/arca.templ | New template for rendering ARCA QR code and CAE information |
| components/regimes/ar/arca_templ.go | Generated Go code from arca.templ template |
| components/regimes/ar/ar.go | New package documentation for Argentine regime support |
| components/bill/invoice.templ | Integrated ARCA QR component into invoice extensions |
| components/bill/invoice_templ.go | Generated Go code with ARCA integration |
| examples/ar-arca-standard.json | Example Argentine invoice with ARCA stamps |
| examples/out/ar-arca-standard.html | Generated HTML output for Argentine invoice |
| examples/credit-note.adjustment.es.json | Updated digest and added tax exemption extensions |
| examples/credit-note-es-es-tbai.json | Updated digest and added tax exemption extensions |
| examples/out/credit-note.adjustment.es.html | Added exemption column to line items and tax tables |
| examples/out/credit-note-es-es-tbai.html | Added exemption column to line items and tax tables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL THE NEW GOBL RELEASE!!
Waiting for invopop/gobl#665