Skip to content

Conversation

@alvarolivie
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2025

Codecov Report

❌ Patch coverage is 81.20301% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.01%. Comparing base (2dad85f) to head (cc7487b).

Files with missing lines Patch % Lines
party.go 37.50% 16 Missing and 4 partials ⚠️
party_parse.go 96.10% 2 Missing and 1 partial ⚠️
context.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   74.84%   75.01%   +0.16%     
==========================================
  Files          25       26       +1     
  Lines        1499     1569      +70     
==========================================
+ Hits         1122     1177      +55     
- Misses        273      286      +13     
- Partials      104      106       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the UBL context handling and party identity management. The main changes include moving context-related code to a dedicated file, introducing support for different CustomizationIDs in UBL output via OutputCustomizationID, and enhancing party identity handling with scope-based categorization (legal/tax).

Key Changes

  • Context definitions moved from ubl.go to new context.go file with added OutputCustomizationID support for French UBL contexts
  • Party identity handling refactored to use scope-based categorization (legal/tax) instead of generic labels
  • PartyIdentification changed from single pointer to slice to support multiple party identifications

Reviewed changes

Copilot reviewed 10 out of 29 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
ubl.go Removed context-related code and imports (moved to context.go)
context.go New file containing all context definitions, including new OutputCustomizationID field for France contexts
context_test.go New comprehensive test suite for context functionality
invoice.go Added logic to use OutputCustomizationID when present and support ubl-profile meta field override
party.go Changed PartyIdentification to slice; refactored identity handling with scope-based logic (legal/tax)
party_parse.go Major refactoring: extracted helper functions for parsing party identities with scope support
party_test.go Updated to use array indexing for PartyIdentification
party_parse_test.go Removed assertions for "CompanyID" label (replaced by scope)
payment_parse_test.go Removed assertions for "CompanyID" label (replaced by scope)
test/data/parse/out/*.json Updated test data reflecting new identity structure with scopes and extensions
test/data/parse/Vat-category-S.xml Formatting cleanup (trailing whitespace removed) and schemeID added to PartyIdentification

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 36 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alvarolivie alvarolivie merged commit e920338 into main Dec 28, 2025
2 checks passed
@alvarolivie alvarolivie deleted the france-update branch December 28, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants