Skip to content

Conversation

@zfergus
Copy link
Member

@zfergus zfergus commented Oct 29, 2025

Description

Organize geometry and math utilities.

Type of change

  • Enhancement (non-breaking change which improves existing functionality)

@zfergus zfergus requested a review from Copilot October 29, 2025 17:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the codebase by moving functionality from the utils module into two new modules: math and geometry. This improves code organization by better separating mathematical utilities from geometric operations.

Key changes:

  • Created new geometry module containing area, angle, intersection, and normal functions
  • Created new math module containing interval arithmetic and mathematical helper functions
  • Moved files from ipc/utils/ to appropriate new modules with corresponding Python bindings
  • Updated all import paths throughout the codebase to reflect the new module structure

Reviewed Changes

Copilot reviewed 37 out of 44 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/ipc/math/* New math module with interval arithmetic and mathematical utilities (formerly in utils)
src/ipc/geometry/* New geometry module with area, angle, intersection, and normal computations
tests/src/tests/math/, tests/src/tests/geometry/ New test directories matching the new module structure
src/ipc/utils/CMakeLists.txt Removed moved files from utils module build
python/src/geometry/, python/src/math/ Python bindings for new modules
Various cpp/hpp files Updated include paths from ipc/utils/ to ipc/math/ or ipc/geometry/

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (e94c11d) to head (dc650e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   97.39%   97.40%           
=======================================
  Files         147      149    +2     
  Lines       23647    23696   +49     
  Branches      795      796    +1     
=======================================
+ Hits        23031    23081   +50     
+ Misses        616      615    -1     
Flag Coverage Δ
unittests 97.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zfergus zfergus merged commit 296fe4a into main Oct 29, 2025
21 checks passed
@zfergus zfergus deleted the geometry-and-math branch October 29, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants