Simplify cmake cuda setup #201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines the CMake CUDA setup by:
Since cuda code is sensitive to environment changes (i.e. IPC fails to build on CUDA 13.0+), enabling it implicitly can create surprises for its consumer. As a library, CUDA build should be guarded behind a cmake option.
Also, ipc-toolkit currently inherits the cuda architecture from Scalable CCD, which defaults to "native" if not defined. Instead, we should handle this explicitly.