Skip to content

Conversation

@iiiian
Copy link
Contributor

@iiiian iiiian commented Dec 8, 2025

This PR streamlines the CMake CUDA setup by:

  • Disabling CUDA builds by default.
  • Set CUDA architecture to native if not specified. Avoid poking into the internal of Scalable CCD.
  • Bump cmake minimum version to 3.24 to support CMAKE_CUDA_ARCHITECTURES="native"

Since cuda code is sensitive to environment changes (i.e. IPC fails to build on CUDA 13.0+), enabling it implicitly can create surprises for its consumer. As a library, CUDA build should be guarded behind a cmake option.

Also, ipc-toolkit currently inherits the cuda architecture from Scalable CCD, which defaults to "native" if not defined. Instead, we should handle this explicitly.

@iiiian iiiian changed the title refactor cuda setup Simplify cmake cuda setup Dec 8, 2025
@iiiian iiiian marked this pull request as draft December 8, 2025 23:44
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (112712c) to head (3b82be6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         149      149           
  Lines       23748    23748           
  Branches      797      797           
=======================================
  Hits        23132    23132           
  Misses        616      616           
Flag Coverage Δ
unittests 97.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zfergus
Copy link
Member

zfergus commented Dec 9, 2025

Can you also add a note about CUDA support to the README.md and docs/source/build/c++.rst files?

@iiiian
Copy link
Contributor Author

iiiian commented Dec 9, 2025

Now IPC will set CMAKE_CUDA_ARCHITECTURES to native if not specified. I also update READMD, build doc, and bump minimal cmake version to 3.24 across the repo. This should work in our CI/CD since Ubuntu 24.04 comes with cmake 3.28 by default.

@iiiian iiiian marked this pull request as ready for review December 9, 2025 02:51
Corrected punctuation and grammar in the README file for clarity.
@zfergus zfergus merged commit c36dd77 into ipc-sim:main Dec 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants