Skip to content

Conversation

@iiiian
Copy link
Contributor

@iiiian iiiian commented Dec 9, 2025

Description

  • Rename sweep_and_tiniest_queue.cpp to .cu.
  • Move cuda cmake setup before ipc_toolkit target definition so cuda architecture is setup properly.

Fixes # (202)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

After the fix ipc-toolkit build successfully with cuda-release profile and cuda toolkit 13.0.

Test Configuration:

  • OS and Version: Fedora 42.
  • Compiler and Version: gcc 15.2 + nvcc 13.0

Checklist

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Notes

Broad phase test for SweepAndTiniestQueue failed. But that's due to another unrelated bug. I will submit a fix tomorrow.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (c36dd77) to head (26a9380).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   97.41%   97.40%   -0.01%     
==========================================
  Files         149      149              
  Lines       23748    23748              
  Branches      798      797       -1     
==========================================
- Hits        23133    23132       -1     
- Misses        615      616       +1     
Flag Coverage Δ
unittests 97.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zfergus zfergus merged commit d2cb640 into ipc-sim:main Dec 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants