[Fusilli] Implemented Layernorm node #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sidorova
force-pushed
the
feature/layer_norm/node
branch
3 times, most recently
from
d7b8357 to
9979c82
Compare
4 tasks
a-sidorova
force-pushed
the
feature/layer_norm/node
branch
2 times, most recently
from
77f22f2 to
e92b893
Compare
Signed-off-by: Alexandra Sidorova <[email protected]>
a-sidorova
force-pushed
the
feature/layer_norm/node
branch
from
e92b893 to
8f2f63e
Compare
a-sidorova
requested review from
IanWood1 and
sjain-stanford
and removed request for
IanWood1
Contributor
Author
|
@IanWood1 @sjain-stanford hi! Could you please start review? |
| layernorm(const std::shared_ptr<TensorAttr> &x, | ||
| const std::shared_ptr<TensorAttr> &scale, | ||
| const std::shared_ptr<TensorAttr> &bias, | ||
| const std::shared_ptr<TensorAttr> &epsilon, |
Member
There was a problem hiding this comment.
The signature for cudnn layernorm only uses 3 tensor inputs: x, scale and bias. Why do we need epsilon to be a Tensor input here?
| // Layer normalization node. | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| class LayernormNode : public NodeCRTP<LayernormNode> { |
Member
There was a problem hiding this comment.
We also need Layernorm backward at some point (follow-on is fine). It's called DLNNode in cudnn: https://sourcegraph.com/github.com/NVIDIA/cudnn-frontend@b372d39879d44c91a8d5b342022e74802b6a8da2/-/blob/include/cudnn_frontend/node/dln.h?L13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of #45