Conversation
* Rename roipac/grimp files to onepass/twopass * Use custom mmap image loader
|
Thanks @rtburns-jpl . Would you please add the description from the parent PR in isce2 as well as all the changes that @vbrancat contributed. |
|
@lijun99 you may want to take a look at this PR. |
|
Thanks @rtburns-jpl ! There is one more bug fix, fix the distance in variance estimate in one-pass workflow. Also, to make it easier for inclusions in both isce2 and isce3, I plan to move future developments of pycuampcor to the independent repo cuAmpcor. Please decide whether you prefer to copy the code over to isce, or use submodule like this. |
|
Also, there are more spelling errors, which are corrected in this commit. |
|
Thanks! Yeah, I agree consuming pycuampcor from a separate repo would make updating it much easier. I'd also like to contribute my CPU-only translation of pycuampcor to your repo, if you're interested. |
|
Sounds great, @rtburns-jpl ! I just sent a collaborator request for cuAmpcor. Maybe we should use a new name like ampcor, under isce-framework or earthdef (Mark's group). |
|
@lijun99 After our upcoming delivery we should discuss the modular approach where PyCuAmpcor will be an external module. That will definitely be a preferred approach over long run. |
hfattahi
left a comment
There was a problem hiding this comment.
Thanks @lijun99 @rtburns-jpl and @vbrancat for this extensive PR, testing and verification. Took a long way to get it here. Based on the test results from @vbrancat LGTM.
|
@rtburns-jpl Let's NOT merge this PR for now as the MCR is not approved. |
Merging upstream changes from Lijun for PyCuAmpcor, and changes from @vbrancat to fix the runconfigs and parsers to support his newly-added parameters
See corresponding PR in isce2 (isce-framework/isce2#922):