Skip to content

Conversation

@maxdexh
Copy link
Collaborator

@maxdexh maxdexh commented Nov 29, 2025

Allows zooming in past fill-screen, as well as zooming on horizontal pdfs in general.

I could not get zooming out past fit-screen to work well because the image dimensions are converted to cells too early (which rounds the aspect ratio). This should be a non-issue since there is no point in doing so right now.

The zooming code is (in my opinion) also a lot more comprehensible now and has some comments explaining what is going on.

@maxdexh maxdexh marked this pull request as ready for review November 29, 2025 19:10
@maxdexh maxdexh changed the title Reimplement zoom to be more general Reimplement zooming in and zooming on horizontal pdfs Nov 29, 2025
@maxdexh maxdexh changed the title Reimplement zooming in and zooming on horizontal pdfs Reimplement zooming to work more generally Nov 29, 2025
Copy link
Owner

@itsjunetime itsjunetime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy shit this works so well; thank you for figuring this all out.

There are a few small nits, mostly about comments, but overall everything is really good. If you want to take care of the nits later as well, I'm fine with that.

On a similar note, are you interested at all in being a co-maintainer? No pressure either way, but I have really appreciated your fixes recently :)

@maxdexh
Copy link
Collaborator Author

maxdexh commented Nov 30, 2025

On a similar note, are you interested at all in being a co-maintainer

Thanks so much for the offer! That'd be great :)

@maxdexh
Copy link
Collaborator Author

maxdexh commented Nov 30, 2025

Oh also I forgot to mention, the early conversion to cells also causes the page to be blurry when zooming in, since we are zooming in on the image, not the pdf. I plan to fix this along with the inability to zoom out in the future, but it will require a larger refactor.

@itsjunetime itsjunetime merged commit 9b9796e into itsjunetime:main Dec 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants