Skip to content

fix: add articleId validation to avoid potential NPE in detail API #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yummyyh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add articleId validation to avoid potential NPE in detail API #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...rc/main/java/com/github/paicoding/forum/web/front/article/rest/ArticleRestController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ public class ArticleRestController {
*/
@GetMapping("/data/detail/{articleId}")
public ResVo<ArticleDetailVo> detail(@PathVariable(name = "articleId") Long articleId) throws IOException {
// === Fix: validate articleId to avoid potential NPE ===
if (articleId == null || articleId <= 0) {
return ResVo.fail("Invalid articleId: " + articleId);
}
ArticleDetailVo vo = new ArticleDetailVo();
// 文章相关信息
ArticleDTO articleDTO = articleService.queryFullArticleInfo(articleId, ReqInfoContext.getReqInfo().getUserId());
Expand Down