Patorcek14patoOriginal sin fronteras y sin límites patch 2 automatically #9
Conversation
* Fix for non-portable builds * submodule update Torch, [TEMP] libultraship * submodule update libultraship * place assets in exe's dir on post build
* Added default menu transition for 3P4P options * Forgot to change the condition * formatting * Reverted change on single frame black Added comments
* try fix ci * use fmt instead * try another fix for fmt * fix link and detect for c++ 20 * invert condition on format
Last time i tested with a new config file this was actually on, despite it showing off. So now it shows ON by default :) Co-authored-by: MegaMech <[email protected]>
…urMasters#542) * Replaced Pop/Push for Yoshi Egg and Mario Sign actors * Removed comments * applied suggestions --------- Co-authored-by: MegaMech <[email protected]>
* Impl SpawnParams * Added json submodule * Update json * Update * Works * Remove comment * Works refactor * Snowman and thwomp working * Impl hot air balloon * More progress * All OObjects are done * cleanup * Refactor 2Dpath to normal path * Update nlohmann json & fix compile * Rest of actors * MORE CHANGES * Finish actors * Done PR, some fix to collision viewer * Impl falling rocks * Add const * wip editor refactor * Property work * continue * Overridable editor properties * Actor saving/loading works now * Fix light alignment * Clarification * Impl penguin * params impl signs * properties impl falling rock * More property impls * impl air balloon * Add spawnParams to OObject Translate * Snowman translate better * impl hedgehog properly * properties impl trophy * thwomp progress * Finish impl properties * Fix compile * Fix cursor collisions * Move registered actors * Rename pathPoint XYZ to xyz * Fix editor pause bug * Clean up * Review comments * Remove SpawnParams struct from actor classes * Rename * Player Label First Iteration * Work now * Working 3d text * Fix boo bug * Finish AText actor * Fix spawnparams compile * Register AText * Finish Text Actor * Fix thwomp interpolation * Fix compile * Fix crab and hedgehog * Fix loading flagpole * Fix Hot Air Balloon * Turn zbuffer on for AText * Update --------- Co-authored-by: MegaMech <[email protected]>
* Update Game.cpp * Update Penguin.cpp
* Update vcpkg.json * fix appimage
* Create RaceManager.cpp * Create RaceManager class for race lifecycle management Added RaceManager class to manage race events lifecycle. * Refactor World class and implement ClearWorld method Refactor World class constructor and destructor. Implement ClearWorld method to delete all objects and reset state. * Add RaceManager to World class * Update ValidateString for editor mode checks Refactor ValidateString to handle editor mode and empty strings. * Update Text.cpp * Add SetText method to Text class * Document RunGarbageCollector function Added documentation for the RunGarbageCollector function. * Refactor Game.cpp by removing dead code Removed unused ruleset handling and clean-up code. * Update Game.h * Remove CM_SpawnFromLevelProps call * Update Text.cpp * Update World.cpp * Add Clean method to RaceManager class * Update RaceManager.cpp * Update World.cpp * Update World.h * Update World.cpp
* Update render_objects.c * Update FrameInterpolation.h * Update render_objects.c * Fix mac compile probably * Fix Mole Dirt Particles * Fix Mole Duplication Bug, probably * Fix drawing using wrong camera bug
* Fix Mole Spawns and Tick Rate * Fix Compile * Actually Fix Compile
* Update RainbowRoad.cpp * Update ChainChomp.cpp * Decrement actor counters in destructor * Update Finishline.cpp
[email protected]:HarbourMasters/SpaghettiKart.githttps://github.com/HarbourMasters/SpaghettiKart.gitgh pr checkout [email protected]
Summary of ChangesHello @patorcek14, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a significant overhaul of the game's underlying architecture, primarily focusing on enabling robust in-game editing capabilities and modernizing the codebase. It introduces a new C++ actor and object system, allowing for more flexible and extensible game entity management. The pathfinding and vehicle systems have been refined to support more complex 3D interactions, and the build process has been updated for better development and deployment. These changes lay the groundwork for a more dynamic and user-friendly development experience, aligning with the "without borders and without limits" theme suggested by the PR title. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and impressive refactoring of the engine, moving towards a more modern C++ actor-based architecture with editor support. Key changes include a new actor registry for data-driven spawning, a RaceManager to orchestrate the game loop, and SpawnParams for flexible actor initialization. Many existing C-style actors and objects have been wrapped or converted to this new system, and numerous files have been updated to support editor functionality and freecam.
Overall, this is a fantastic step forward for the project's architecture and maintainability. I've found one critical issue related to asset loading in the new AActor::Draw method that will cause a crash, and one medium-severity issue regarding code duplication between setup_race and the new setup_editor function. Addressing these will make this large-scale improvement even better.
| ApplyMatrixTransformations(mtx, *(FVector*)Pos, *(IRotator*)Rot, Scale); | ||
| if (render_set_position(mtx, 0) != 0) { | ||
| gSPDisplayList(gDisplayListHead++, Model); | ||
| gSPDisplayList(gDisplayListHead++, (Gfx*)Model); |
There was a problem hiding this comment.
The Model member is a const char* representing a resource path, but it's being cast directly to Gfx*. This will lead to a crash. You should use LOAD_ASSET_RAW to load the resource first.
| gSPDisplayList(gDisplayListHead++, (Gfx*)Model); | |
| gSPDisplayList(gDisplayListHead++, (Gfx*)LOAD_ASSET_RAW(Model)); |
|
Sorry I'm just seeing this now. |
7 participants
No description provided.