Was breaking on Linux (by assuming backslash file separator)

[tastapod]

I removed the leading .\ from node_modules (it wasn't adding anything) and used os.path.basename instead of splitting on ''. Seems to work ok, although I haven't tried it on Windows.

[japj]

thanks for running it on linux! (I started it because npm initially didn't work on windows).

note though, that I think this patch breaks support for python3+ due to http://docs.python.org/release/3.0.1/whatsnew/3.0.html#print-is-a-function

I will run some tests on the different python versions later today (don't have access to my test machine at the moment)

[tastapod]

Oh, my bad. I always remove the parens on print to remind myself it's
different from the other kids. I'll revert that and update the pull request.

On 23 November 2011 10:56, Jeroen Janssen <
[email protected]

wrote:

thanks for running it on linux! (I started it because npm initially didn't
work on windows).

note though, that I think this patch breaks support for python3+ due to
http://docs.python.org/release/3.0.1/whatsnew/3.0.html#print-is-a-function

I will run some tests on the different python versions later today (don't
have access to my test machine at the moment)

---

Reply to this email directly or view it on GitHub:
#11 (comment)